search

joomla / statistics-server

Server for collecting environment stats for Joomla Installations
GNU General Public License v2.0
11 stars 17 forks source link

Jenkins doesn't run database migration script #45

Closed wilsonge closed 4 years ago

wilsonge commented 4 years ago

It currently runs the update script but not php bin/stats database:migrate - assuming it should but to check before I make changes. Ran manually in terminal for now. Presumably related to https://github.com/joomla/statistics-server/issues/36

mbabker commented 4 years ago

I’d leave it out just because things don’t parse the SQL files well (PDO doesn’t like the delimiters or something, I forget what).

wilsonge commented 4 years ago

If we're leaving it out then we may as well keep the triggers in if we're just going to manually run the things through phpmyadmin?

mbabker commented 4 years ago

Can't, then you catastrophically break the testing setup.

mbabker commented 4 years ago

(Or, you end up with a lot of copies of the SQL schema floating around and the test environment doesn't work with any of the production resources, which kind of defeats the purpose)

wilsonge commented 4 years ago

OK I'll just document it https://github.com/joomla/statistics-server/pull/46 - if you could review and add anything i'm missing