joomlagerman / joomla

The J!German translation team provides German translation for Joomla!
https://www.jgerman.de
GNU General Public License v2.0
25 stars 46 forks source link

[5.1] Add toolbar buttons in language installation toolbar #3085

Closed jgerman-bot closed 8 months ago

jgerman-bot commented 8 months ago

New language relevant PR in upstream repo: https://github.com/joomla/joomla-cms/pull/42610 Here are the upstream changes:

Click to expand the diff! ```diff diff --git a/administrator/components/com_installer/src/View/Languages/HtmlView.php b/administrator/components/com_installer/src/View/Languages/HtmlView.php index 4cd75a8a0c5ae..0081169df0382 100644 --- a/administrator/components/com_installer/src/View/Languages/HtmlView.php +++ b/administrator/components/com_installer/src/View/Languages/HtmlView.php @@ -16,7 +16,6 @@ use Joomla\CMS\Language\Text; use Joomla\CMS\MVC\View\GenericDataException; use Joomla\CMS\Toolbar\Toolbar; -use Joomla\CMS\Toolbar\ToolbarHelper; use Joomla\Component\Installer\Administrator\View\Installer\HtmlView as InstallerViewDefault; // phpcs:disable PSR1.Files.SideEffects @@ -75,15 +74,19 @@ public function display($tpl = null) */ protected function addToolbar() { - $canDo = ContentHelper::getActions('com_installer'); + $canDo = ContentHelper::getActions('com_languages'); $toolbar = Toolbar::getInstance(); - ToolbarHelper::title(Text::_('COM_INSTALLER_HEADER_' . $this->getName()), 'puzzle-piece install'); + if ($canDo->get('core.manage')) { + $toolbar->linkButton('list', 'COM_INSTALLER_TOOLBAR_MANAGE_LANGUAGES') + ->url('index.php?option=com_languages&view=installed'); + $toolbar->linkButton('comments', 'COM_INSTALLER_TOOLBAR_MANAGE_CONTENT_LANGUAGES') + ->url('index.php?option=com_languages&view=languages'); + $toolbar->divider(); + } - if ($canDo->get('core.admin')) { - parent::addToolbar(); + parent::addToolbar(); - $toolbar->help('Extensions:_Languages'); - } + $toolbar->help('Extensions:_Languages'); } } diff --git a/administrator/language/en-GB/com_installer.ini b/administrator/language/en-GB/com_installer.ini index fa3a097afedcf..0522dc8f2c372 100644 --- a/administrator/language/en-GB/com_installer.ini +++ b/administrator/language/en-GB/com_installer.ini @@ -229,6 +229,8 @@ COM_INSTALLER_TOOLBAR_FIND_UPDATES="Check For Updates" COM_INSTALLER_TOOLBAR_INSTALL="Install" COM_INSTALLER_TOOLBAR_INSTALL_EXTENSIONS="Install Extensions" COM_INSTALLER_TOOLBAR_MANAGE="Manage Extensions" +COM_INSTALLER_TOOLBAR_MANAGE_CONTENT_LANGUAGES="Content Languages" +COM_INSTALLER_TOOLBAR_MANAGE_LANGUAGES="Manage Languages" COM_INSTALLER_TOOLBAR_PURGE="Clear Cache" COM_INSTALLER_TOOLBAR_UPDATE="Update" COM_INSTALLER_TYPE_CLIENT="Location" ```
tecpromotion commented 8 months ago

We can wait for https://github.com/joomla/joomla-cms/pull/42663