search

joomlatools / joomlatools-composer

Composer extension installer for Joomla.
https://www.joomlatools.com/developer/tools/composer/
GNU General Public License v3.0
52 stars 13 forks source link

Joomlatools Framework files not properly moved on Joomlatools Platform #14

Closed raeldc closed 5 years ago

raeldc commented 9 years ago

We're trying to install Nooku 2.x on the Joomla Platform. It seems that the joomlatools-installer didn't move files properly.

/libraries/koowa wasn't moved to lib/libraries/koowa /media wasn't moved to /public/media /administrator/manifests/files/files_koowa/script.php wasn't moved to /app/administrator/manifests/files/files_koowa/script.php

johanjanssens commented 9 years ago

@stevenrombauts Does this issue need further follow-ups ?

stevenrombauts commented 9 years ago

@johanjanssens Yes this needs to be looked at. Also, this issue should actually be in the nooku/nooku-installer repository as its related to that one. The installer there needs to get the changes ported over to add support for platform. But since we actually decided to only install reusable components with nooku-installer we need to update the framework and related repositories to rely on this installer (joomla-composer) instead of nooku-installer. All composer.json files needs to be updated and tested for that to work.

raeldc commented 9 years ago

@stevenrombauts, I'd like to move this to the Nooku Installer repository. But I don't have the right permissions to submit a report.

stevenrombauts commented 9 years ago

@raeldc No worries :) We will be consolidating the installation features into this repository anyway. Will discuss further with Johan and then we can solve it once and for all.

johanjanssens commented 9 years ago

@stevenrombauts We still have this one to fix ?

stevenrombauts commented 9 years ago

@johanjanssens Yes, this should theoretically fix itself by going back to the joomlatools composer installer instead of the nooku/installer plugin. It's on the list.

johanjanssens commented 8 years ago

@stevenrombauts Can we also look into fixing this one this week.

johanjanssens commented 8 years ago

@stevenrombauts Whats the status on this one ?

johanjanssens commented 8 years ago

More details: Right now only joomlatools/joomlatools-composer includes fixes to handle the new paths in the platform. Solutions to resolve this issue are:

  1. Move the fixes to nooku-installer (to be forked as joomlatools-framework-installer)
  2. Change the installer for the framework to joomlatools-composer instead of nooku-installer
stevenrombauts commented 5 years ago

No longer needed, joomlatools-framework can be installed through Composer on both Platform and Joomla today.

Also, Composer method is proving too complicated and error-prone to make this worth our time for CI projects. (see https://github.com/joomlatools/www.joomlatools.com/issues/940)