joomlatools / joomlatools-composer

Composer extension installer for Joomla.
https://www.joomlatools.com/developer/tools/composer/
GNU General Public License v3.0
52 stars 13 forks source link

Installer fails with platform extensions #22

Closed stevenrombauts closed 7 years ago

stevenrombauts commented 8 years ago

The installer will throw an exception when trying to install platform-xyz extensions into platform along with the default dependencies on a first composer install during installation of custom projects. This happens because the dependencies required to bootstrap the application (such as phptdotenv) are missing. We need to make sure that:

Originally reported at joomlatools/joomlatools-platform#240

Todo's:

stevenrombauts commented 8 years ago

@raeldc If you have 2 minutes to spare, could you test this? I've created a gist that sets everything up for you, all you need to do is verify that the installation works on your Joomlatools Box:

The following sets up Joomlatools Platform develop, adds extra components to composer.json and then installs it all in one go. Run this command:

curl -s https://gist.githubusercontent.com/stevenrombauts/fefee1e50135d0c766fd/raw/f0595859b423b54313397f388c993d760ec0e7e8/test-composer.sh | bash

Login at http://joomla.box/composertest/web/administrator and check if com_content, com_media and com_finder have been installed (and are working)

Thanks!

raeldc commented 8 years ago

@stevenrombauts,

I'm having this error when running the script.

screen shot 2016-03-07 at 4 35 39 pm

stevenrombauts commented 8 years ago

Thanks @raeldc for testing! Looks like this constant has only recently been added to Composer in 49d7d659. Not many people will have such a recent version so I went back to relying on the Symfony Console constants.

Could you give that test command above another run please?

raeldc commented 8 years ago

@stevenrombauts, it's working perfectly now. Awesome!

johanjanssens commented 7 years ago

@stevenrombauts @raeldc This issue is still marked as test. Did we release this? If so where, if not where should this go?

stevenrombauts commented 7 years ago

@johanjanssens We still need to release this. This should be working but to make it work properly in platform we also need to fix #23. But this should be mergeable.

johanjanssens commented 7 years ago

@stevenrombauts Can you check with @ercanozkaya This code was committed in develop and it seems it has been released with 1.1.0. Trying to clean this up a bit so the state of the repo reflects the work done, or things will get blurry after a while.

ercanozkaya commented 7 years ago

This was released as part of v1.1.0