search

joomlatools / joomlatools-composer

Composer extension installer for Joomla.
https://www.joomlatools.com/developer/tools/composer/
GNU General Public License v3.0
52 stars 13 forks source link

Media files not properly moved in Joomlatools Platform #43

Closed allanpilarca closed 5 years ago

allanpilarca commented 5 years ago

This PR willl fix the media files path for joomlatools-platform.

close #42

stevenrombauts commented 5 years ago

@allanpilarca Thanks Allan. Code looks good to me. Is there any particular extension I should test this with?

allanpilarca commented 5 years ago

hi @stevenrombauts thanks! You can try to test installing joomlatools-framework or joomlatools-platform-content.

stevenrombauts commented 5 years ago

@allanpilarca Thanks! I took another look at your code and realised that the change you made is only related to a joomlatools-component package (our reusable FW components). For example: joomlatools/framework-files

The Composer installer will always tell you what type of component it is installing:

$ composer require joomlatools/framework-files
...
Installing the Joomlatools Platform extension joomlatools/framework v3.2.3
Installing the Joomlatools Platform reusable component joomlatools/framework-files v3.2.0
...

These are special cases that we handle ourselves in the Composer plugin.

I verified that the files have been installed properly with:

$ ls -lah web/media/koowa/com_files/
css/  img/  js/   scss/

However, packages such as joomlatools/framework or joomlatools/platform-content are "regular" Joomla installer packages and are simply being passed on to the Joomla (Platform) installer. If they are not being installed correctly, you'll need to debug the installer there. It could be that the installer is not correctly picking up on any of the XML manifests that tell it to include the media files.