search

joonas-fi / joonas.fi

My personal blog
https://joonas.fi/
Apache License 2.0
3 stars 1 forks source link

Fix unresponsive NavBar on small screens. #107

Open TunaCici opened 1 year ago

TunaCici commented 1 year ago

Hello Joonas!

Just recently I forked this (joonas.fi) repository and started using it as the reference blog application for myself. Everything is pretty good so far (e.g. I managed to deploy on my website & am in the process of putting my own personal stuff). So, first thing first, thanks for the project and making it open source with Apache license!

During my testing I've noticed that the navigation bar on small screens does not work properly. I tried to follow some fixes on hugo-theme-cactus, but they just broke thing for the worse.

So, I implemented my own "fix". It's not perfect, but it gets the job done >.<

I noticed the same problem on your page: joonas.fi. Just visit the page on your phone (I've used my iPhone XS /w Safari). Here's some of the things that is "broken":

I believe you might want to also fix it on your site as well. This PR "fixes" it, but you can also upgrade your hugo-theme-cactus. They both work, but I find the upgrade way a bit tedious and not worth it >.<

First, I fixed the button "not working" by fiddling with header.html and main.js around. It worked, but this time the sub sections (<li> elements) just looked all misaligned and weird. For that, I did some CSS "work" to align everything. As of now, only the style-white.css is modified since you [and I] only use that theme on our sites.

P.S. I wanted to contact you after everything was complete, but anyways; Thanks, again, for making your site open source! I really appreciate it.

Here's the before and after in video format (shot on my iPhone XS /w Safari).

https://github.com/joonas-fi/joonas.fi/assets/36923239/b4a98002-dc71-44d2-bcd5-d1f5b39d1b83

https://github.com/joonas-fi/joonas.fi/assets/36923239/a438b025-0763-430b-a4d2-4ed043ca7b6c

joonas-fi commented 11 months ago

First off, sorry for taking a long time to react to this. Lots of life changes (positive), but sadly very little time to do software projects on my free time. :smile:

Thank you very much for the fix, I will test it and accept the PR when I have more time!

I am super impressed by you sending both before and after video of the fix! Awesome work.

Have a nice weekend!

joonas-fi commented 11 months ago

It was also nice to hear that forking this repo helped you get started :+1: Nice to hear stories like these.