search

joonhocho / react-native-linkedin-sdk

React Native Wrapper for Latest LinkedIn Mobile SDK for Sign-In / Auth and API Access.
MIT License
40 stars 16 forks source link

Handle Android RN 0.47 breaking change #17

Closed GaborWnuk closed 7 years ago

joonhocho commented 7 years ago

@GaborWnuk Is this backward compatible with no side effects? What does it do?

chaitanya-bhagavan commented 7 years ago

@joonhocho React native 0.47 has a breaking change where public List<Class<? extends JavaScriptModule>> createJSModules() has been removed from ReactPackage interface. This PR removes @Override annotation to be compatible with RN > 0.47. This is backward compatible with RN <0.47

joonhocho commented 7 years ago

@chaitanya0bhagvan Thanks for explanation. Merged!