joonson / syncnet_python

Out of time: automated lip sync in the wild
MIT License
652 stars 146 forks source link

python2 Vs python3 #19

Closed DavidDoukhan closed 4 years ago

DavidDoukhan commented 4 years ago

Dear @joonson ,

First of all I'd like to thank you for this software that is quite impressive!

I managed to run your code with python3 without any problems.

However, when I first rode the instructions found in the README.md , you suggested to use python 2.7 . I tried to launch your program using python 2.7, but I faced few problems: In scripts run_syncnet.py and run_visualise.py , you call function pickle.load with 2 arguments: the name of the pickled file AND an "encoding" named argument. The "encoding" named argument is only supported in Python 3. When I removed this encoding argument from the 2 scripts, the code worked fine.

So here are my suggestions:

joonson commented 4 years ago

The code has been updated to use Python 3. Thanks for the suggestion.