joonson / syncnet_python

Out of time: automated lip sync in the wild
MIT License
652 stars 146 forks source link

Is it okay that elements are removed from framefaces list while iterating over it? #52

Open hannarud opened 2 years ago

hannarud commented 2 years ago

In the file there is a for cycle over framefaces variable, and inside that cycle framefaces gets modified (faces that are already tracked are removed): https://github.com/joonson/syncnet_python/blob/6efbb1c305c23f47a62b09cf4215a8ac45e97d49/run_pipeline.py#L77 I'm not sure if this behavior is okay, because it may mean we loose some of the frames? At the same time, it all is getting executed in while loop, so maybe in the end the data is not lost. I might try to rewrite this, if the problem really exists. But maybe it's not. Do you think it is a problem? Should it be fixed?

qwert1887 commented 8 months ago

I'm confused too @hannarud