joonty / vim-phpqa

PHP QA tools for Vim
http://www.joncairns.com
MIT License
290 stars 32 forks source link

fixed errors in vim 7.4.264 caused by more strict function names #19

Closed FunTimeCoding closed 10 years ago

FunTimeCoding commented 10 years ago

I believe this is my first PR.

joonty commented 10 years ago

Thanks very much for this @FunTimeCoding!

paprykarz commented 10 years ago

This patch give me

Error detected while processing BufRead Auto commands for "*":
E117: Unknown function: Phpqa#PhpLint

when file is loaded into the buffer and

Error detected while processing function PhpqaRunAll:
line    3:
E117: Unknown function: Phpqa#PhpLint
E15: Invalid expression: Phpqa#PhpLint()
line    4:
E121: Undefined variable: retval
E15: Invalid expression: 0 == retval && 1 == g:phpqa_run_on_write

when attempting to write the buffer.

codemedic commented 10 years ago

I am having the same problem .... is there any more info that I can provide to help identify the real issue.

codemedic commented 10 years ago

I fixed the bundle to rev d9ae70d874698dae507d4256e4608ff8bd3bc61d and it started behaving!

FunTimeCoding commented 10 years ago

I would guess that the new function name constraints are not backwards compatible. How confusing. I did this with some help in #vim on freenode. Maybe we can ask for advice there again.

joonty commented 10 years ago

That was a pretty spectacular change that Vim introduced, in a patch level update! Oh well. Seems to be working, thanks @FunTimeCoding.

FunTimeCoding commented 10 years ago

you're welcome~

skotos commented 10 years ago

Like codemedic & paprykarz, this patch breaks phpqa with:

Error detected while processing BufRead Auto commands for "*":
E117: Unknown function: Phpqa#PhpLint

FYI: I am running vim 7.3.547 I will be pinning vundle to 20754e7d3a6d299e57f55d544d0a07385da2088e until this is fixed.

FunTimeCoding commented 10 years ago

can you try and figure out what convention vim < 7.4.264 expects?

skotos commented 10 years ago

See pull request #20