search

joonty / vim-phpqa

PHP QA tools for Vim
http://www.joncairns.com
MIT License
290 stars 32 forks source link

Quickfix window open even with no errors #5

Closed tyjak closed 11 years ago

tyjak commented 11 years ago

php -l myfile.php return "No syntax errors detected in myfile.php" and show up in the quickfix window as an error.

The fix I made in autoload/phpqa.vim line 92

if 0 != len(l:php_list) && match(l:php_list[0],"No syntax errors") == -1

Thanks for your awesome plugin, very useful !

joonty commented 11 years ago

Hi, thanks for that, I'll test and integrate into the repo.

Incidentally, which version of PHP are you using?

Thanks

joonty commented 11 years ago

Hi, any update on your PHP version? Just interested really.

When I run php -l <file.php> 1>/dev/null I get no output, but it seems your version spits "No syntax errors..." into standard error, which is confusing things.

Your fix works fine for my version as well, so I'll put it in the master branch. Thanks