search

joonty / vim-phpqa

PHP QA tools for Vim
http://www.joncairns.com
MIT License
290 stars 32 forks source link

Allow for built-in phpmd rules #7

Closed mikedfunk closed 11 years ago

mikedfunk commented 11 years ago

It took me a while to set this up because I had to add a phpmd_ruleset.xml that just used the 4 default rulesets. It would be nice if you could just specify any default rulesets to use in .vimrc so a ruleset.xml is not required.

It would also be nice where if you didn't specify any it would default to all of the default 4 rulesets or something so it would just work out of the box.

joonty commented 11 years ago

Hi, very sorry for the long delay on this. I need Github to keep spamming me about issues that I forget to go back to!

This is a good idea, so all I've done is take the validation out of the mess detector ruleset. Now, you pass in exactly what you would to the third argument of phpmd: it can be an XML file, built in rule (e.g. codesize) or comma separated list of a mixture of these.

Also, as with your suggestion, I've made the default to be: codesize,unusedcode,naming. This will allow it to work straight away.

Thanks for your patience.