search

joopert / nad_receiver

python api to connect to NAD receivers
MIT License
12 stars 18 forks source link

NADTelnet: Fix initial telnet open connection #42

Closed andreas-amlabs closed 4 years ago

andreas-amlabs commented 4 years ago

NAD telnet firmwares behave differently and some firmwares output a lot of initial data like settings from BlueOS

andreas-amlabs commented 4 years ago

You want any changes to this PR ?

andreas-amlabs commented 4 years ago

Any comments on this on ? I would like to see it merged even though it does not fix ALL issues, it does fix some of them!

andreas-amlabs commented 4 years ago

@joopert: Could you please merge this as the row 91 fixes a real potential issue

Thanks

gladhorn commented 4 years ago

I'd like to make an attempt to find a solution without using a defined number of lines to be read. As you say, the firmware changes, and we cannot expect users to change some constant that hardly makes sense without knowing how the firmware behaves.

gladhorn commented 4 years ago

Ah, you updated, great, I think this looks good :)