Upgrade Ruby versions and Relax dependancies

joost / phony_rails

This Gem adds useful methods to your Rails app to validate, display and save phone numbers. It uses the super awesome Phony gem (https://github.com/floere/phony).

MIT License

555 stars 111 forks source link

Upgrade Ruby versions and Relax dependancies #192

Closed berkos closed 5 years ago

berkos commented 5 years ago

👋

Upgrade to latest Rubies on Travis.
Remove Gemfile.lock to relax dependancies between different Ruby versions.
Fix offences in latest Rubocop. (Should the version of rubocop locked?)

note: Gemfile.lock is bundled with a specific version of bundler, not sure if there is a reason to keep the lock file as versions can locked from gemspec.

Thanks!

coveralls commented 5 years ago

Coverage decreased (-0.0006%) to 99.825% when pulling 572a55269de40feb036e4086c9e2eedddc4b1ff2 on berkos:upgrade_Ruby_versions_on_travis into 22d06c8cf3958f3b590756defdb03cad33b2c918 on joost:master.

joost commented 5 years ago

Thanks. Useful changes.

berkos commented 5 years ago

Thanks for the response and merging the PR. If we find that Rubocop keeps finding new offences when updates to the latest version we could lock Rubocop version as development dependancy.