search

joost / phony_rails

This Gem adds useful methods to your Rails app to validate, display and save phone numbers. It uses the super awesome Phony gem (https://github.com/floere/phony).
MIT License
555 stars 111 forks source link

Test fixes - No mongoid #207

Closed joost closed 3 years ago

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.002%) to 99.828% when pulling cf6fe44466e093252bfd48df2c1087c9db06effb on no_mongoid into dbbce07b7b31fb7f51e2ec1455239168ca2fcddf on master.

mattruzicka commented 2 years ago

@joost Was "mongoid" removed because them gem isn't Ruby 3 compatible or was it some other reason? I'm in the process of a Ruby 3 upgrade with Mongoid (no issue so far). I'm curious if you'd be willing to bring back support. I'll probably have some time to spend on this.

joost commented 2 years ago

@mattruzicka if I remember correctly some issues with changes on the Mongo side of things. You're very welcome to fix those and re-introduce. May only be some simple changes of the previous code.