search

joost / phony_rails

This Gem adds useful methods to your Rails app to validate, display and save phone numbers. It uses the super awesome Phony gem (https://github.com/floere/phony).
MIT License
556 stars 111 forks source link

Remove old gem post-install message #208

Closed ameketa closed 1 year ago

ameketa commented 3 years ago

The post-install warning message introduced with PhonyRails v0.10.0 (which was released in 2015) is no longer relevant, as the behavior described has been in place for over 8 years.

This change removes the post-install message.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 99.828% when pulling 8d2e7e19ed8cba7e700e11367c37837eec0827ce on ameketa:remove-old-post-install-message into ae1fc15ac42b33c7fec273a95f2f7c15984e98fd on joost:master.

ameketa commented 1 year ago

@joost just updated my branch; do you have any thoughts on this PR?

joost commented 1 year ago

Hi @ameketa, why don't you like the post install msg?

ameketa commented 1 year ago

Hi @joost -- first of all, thank you for making this. I've been using it for the past several years and it's great!

I think it made sense to include this post-install message as a warning back in 2015 when the change was first made, but it seems fair to say that 8 years later it's a message that's no longer relevant to anyone, since this behavior has been in place for so long. In terms of why I'd recommend cleaning up outdated post-install messages, they just appear any time you bundle install in a new environment, and if you frequently see outdated or irrelevant messages, it decreases the utility of the post-install messages as a whole. Lots of important breaking changes happen over 10+ years of a library's life; I'd recommend putting those kinds of changes into a Changelog file instead?