Closed gregnwosu closed 4 years ago
The CDLHARAMI definition is not implemented yet.
I can send a PR for this if you prefer
Yes, you can do a pull request if it's only depends on the Python 3 standard library.
I would like to see an output for all pattern recognition definitions as follows:
If there is a bullish harami then output is 1 If there is a bearish harami then output is -1 Else (if no harami) output is 0
Also, if you can provide a source definition where we can check and validate the output would be very helpful. A source definition can be an online url with definition explanation or a book title where the source definition is defined.
Describe the bug harami detection is failing for the following dataframe
To Reproduce
Expected behavior A clear and concise description of what you expected to happen.
Screenshots The fourth candle from the left should be detected as harami
Desktop (please complete the following information):
Additional context Add any other context about the problem here.