joostkremers
commented
2 years ago Just thought this might be fun. I wanted crossref fields to be clickable, to open the relevant entry, after the fashion of
file,doietc.
Sure, why not.
I've got a couple of questions though:
* first, why is the functionality for clickability implemented with an ebib-specific mechanism (`ebib-index-open-at-point` and `ebib-entry-open-at-point`) rather than with the standard Emacs `button` libary and functions?
Probably because I was just copying from similar functionality in the index buffer (where the notes symbol and doi/url fields are clickable) without knowing what I was really doing.
I've used Emacs buttons a lot in my own display functions for the index buffer and they work great, but the ebib-specific stuff initially confused me.
* second, is there a reason there are separate functions for opening-at-point in the index and entry buffers?
The functions for the index buffer were originally provided by someone else and at some point I basically copied them for the entry buffer. I'm not familiar with buttons in Emacs and at the time I probably didn't even realise they existed.
It would make sense to replace the Ebib-specific stuff with more standard methods, but I have little time myself. I'd happily accept a PR, though.
Hugo-Heagren
Just thought this might be fun. I wanted crossref fields to be clickable, to open the relevant entry, after the fashion of
file,doietc. I followed the pattern used for those fields in my implementation.I've got a couple of questions though:
ebib-index-open-at-pointandebib-entry-open-at-point) rather than with the standard Emacsbuttonlibary and functions? I've used Emacs buttons a lot in my own display functions for the index buffer and they work great, but the ebib-specific stuff initially confused me.