search

joostkremers / ebib

A BibTeX database manager for Emacs.
https://joostkremers.github.io/ebib/
BSD 3-Clause "New" or "Revised" License
272 stars 37 forks source link

Don't uniquify already unique keys #277

Closed leinfink closed 7 months ago

leinfink commented 1 year ago

If ebib-uniquify-keys is non-nil, ebib-generate-autokey on an entry that currently has a unique key will produce a new unique key by adding or changing the alphabetical postfix.

This is unexpected if that is the only change between the old and new key. I think the expected behavior would be to keep the old key if the new key would differ only (unnecessarily) in the uniquified postfix. That is, using ebib-generate-autokey on a key with a different format, e.g., a default key like <new-entry>, should of course still return a new key even if the old key was already unique.

joostkremers commented 1 year ago

Thanks for reporting this. It seems like a bug. I'll try and find a fix for it as soon as I have some time.

joostkremers commented 7 months ago

Well, it took a while, but I finally had a look and fixed this issue. Thanks for reporting it.

leinfink commented 7 months ago

Wonderful, thanks!