Implement external package notes integration

joostkremers / ebib

A BibTeX database manager for Emacs.

https://joostkremers.github.io/ebib/

BSD 3-Clause "New" or "Revised" License

272 stars 37 forks source link

Implement external package notes integration #298

Closed swflint closed 2 months ago

swflint commented 2 months ago

This PR provides a relatively simple way to hook into existing notes infrastructure. I have lightly tested this, and have verified that :has-note, and :open-note will work with citar (separate PR forthcoming to provide a citar integration file), but have not yet verified that note creation will work (note creation will likely take more complex code).

See #263 and pprevos/citar-denote#28.

joostkremers commented 2 months ago

Sounds like a good idea.

The file ebib-external-notes.el, for which a require is added, isn't in the repo yet, though, right?

swflint commented 2 months ago

It is not, nor is it necessary, given the way I modified things. It had been, but I thought it made more sense to streamline it. Fixed.

joostkremers commented 2 months ago

Closing this since the commits are also part of PR #299 .