search

joostkremers / writeroom-mode

Writeroom-mode: distraction-free writing for Emacs.
BSD 3-Clause "New" or "Revised" License
611 stars 28 forks source link

First call doesn't set margins correctly #2

Closed ewstearns closed 10 years ago

ewstearns commented 11 years ago

I'm using a recent pull of the the development branch with homebrew. (version: GNU Emacs 24.3.50.1 (i386-apple-darwin11.4.2, NS apple-appkit-1138.51) of 2013-07-12 on xxx). I also got the same result on the release 24.3. I pulled writeroom-mode from melpa. I have customized writeroom-width to 100, but leaving this at default seem to make a difference for my problem.

For the first buffer where I call writeroom-mode, the full screen opens correctly, but the margins are not set correctly. It appears that window-body-width returns the pre-fullscreen size instead of the post-fullscreen size. Calling writeroom-mode on another buffer sets the margins correctly.

joostkremers commented 11 years ago

Fullscreen Emacs is problematic on OS X (although ISTR that this is being worked at), so I generally disable it myself. I suspect that this is more of an Emacs problem than a problem with writeroom-mode, but unfortunately, I don't have the time right now to look into it more thoroughly. It'll be a few weeks (mid-August at the earliest) before I can do that.

Fullscreen seems to be better with the emacs-mac-port at https://github.com/railwaycat/emacs-mac-port, so perhaps you want to give that a try.

I'll get back to this issue as soon as I have the time.

joostkremers commented 10 years ago

Is this still an issue? I made some changes to writeroom-mode recently that also affect fullscreen, so I was wondering. Can't really test it myself since I don't have easy access to a Mac ATM.

ewstearns commented 10 years ago

Yes, this seems to work better in my mac os x environment.

On Mon, Mar 24, 2014 at 5:20 PM, Joost Kremers notifications@github.comwrote:

Is this still an issue? I made some changes to writeroom-mode recently that also affect fullscreen, so I was wondering. Can't really test it myself since I don't have easy access to a Mac ATM.

— Reply to this email directly or view it on GitHubhttps://github.com/joostkremers/writeroom-mode/issues/2#issuecomment-38502687 .

joostkremers commented 10 years ago

Ok, I'll close the issue then. Let me know if you run into problems again and I'll see what I can do.