search

joostn / OpenJsCad

3D solid CAD using only Javascript
315 stars 128 forks source link

Remove degenerate polygons after canonicalization #62

Closed joostn closed 9 years ago

joostn commented 9 years ago

see https://github.com/joostn/OpenJsCad/issues/60

If a polygon had two vertices very close together, these may become truly identical vertices after canonicalization. fixTJunctions choked on this.

Fix: canonicalization removes identical vertices from polygons. Because fixTJunctions does implicit canonicalization, the problem cannot occur anymore.

bebbi commented 9 years ago

nice! that seems to work just fine. #40 unfortunately seems unrelated.