joostvunderink / angular-jsonrpc-client

A JSON-RPC 2.0 client for AngularJS
MIT License
26 stars 20 forks source link

Update to be compatible with Angular 1.6 #19

Open ben-8409 opened 7 years ago

ben-8409 commented 7 years ago

The promise.success / error functions were deprecated a while ago and remove in Angular 1.6.

Update the source to use then/catch as described in the angular js migration guide: https://docs.angularjs.org/guide/migration#migrate1.5to1.6-ng-services-$http

I tested this in one app and it seems to work fine, though I cannot guarantee there are no breaking changes.

jpike88 commented 6 years ago

@ben-8409 @joostvunderink this one is pretty important. What can I do to make speed this along?

jpike88 commented 6 years ago

I'm about create a new npm package called 'angular-jsonrpc-client-ng-1.6' or something, this looks like it's going nowhere.

jpike88 commented 6 years ago

https://www.npmjs.com/package/ng-jsonrpc-client