joouha / euporie

Jupyter notebooks in the terminal
https://euporie.readthedocs.io
MIT License
1.54k stars 36 forks source link

Unable to display Latex on foot terminal #101

Closed MightyPlaza closed 4 months ago

MightyPlaza commented 4 months ago

Using version 2.7.0, on foot terminal, I am unable to render anything with Latex (IPython.display or Markdown). Using matplotlib.pyplot plots a graph as expected On kitty everything works as expected (behaviour does not change for foot or kitty with/without "graphics": "sixel") Unsure if this is an issue with my system

Other minor (unrelated) issues I've found:

Thanks for awesome project

joouha commented 4 months ago

Hi,

  1. If LaTeX rendering is working as expected in kitty, you probably need to install a program which can convert from png to sixel, such as chafa, imagemagick, or the chafa.py python package.

    Kitty can display png images directly using the kitty graphics protocol, whereas foot can only display sixel graphics, so euporie needs some way to convert images into sixels.

  2. I think this file saving issue might already fixed in the dev branch. Could you explain exactly what's happening in a bit more detail for me?

  3. I've added default values for the custom color config options in dev, which should fix this 🤞

  4. I'll take a look at the numlock issue tomorrow. I thought I'd already fixed it, so thanks for letting me know it's still not working!

MightyPlaza commented 4 months ago
  1. If LaTeX rendering is working as expected in kitty, you probably need to install a program which can convert from png to sixel, such as chafa, imagemagick, or the chafa.py python package.

tried installing all 3 and restarting euporie, still no output on foot

  1. I think this file saving issue might already fixed in the dev branch. Could you explain exactly what's happening in a bit more detail for me?

If I don't specify the .ipynb at the end of the name when creating a new file, nothing happens. It permanently says Saving... in the corner

joouha commented 4 months ago

Ok, got it, thanks.

I've made a fix for the issue with saving notebooks without a file extension (a41b3b595073b4e62e020617c46c4451f87b6c1d), which will be in the next release.

The issue with LaTeX in foot is fixed in dev branch, so should work in the next release.

joouha commented 4 months ago

I've just released v2.8.0, which should fix the issues reported here

MightyPlaza commented 4 months ago

can confirm all issues have been fixed (tab with numlock on still doesn't work, but the rest of the keys seem to work now) thanks for the help

joouha commented 4 months ago

Thanks. I've released published v2.8.1 with a (untested) fix for the tab key.

MightyPlaza commented 4 months ago

can confirm it works thanks again