Open in external editor fails

joouha / euporie

Jupyter notebooks in the terminal

https://euporie.readthedocs.io

MIT License

1.54k stars 36 forks source link

Open in external editor fails #20

Closed yingzhu146 closed 2 years ago

yingzhu146 commented 2 years ago

When pressing e I'm getting the following warning, and the process never completes.

/1ib/python3.9/site-packages/euporie/commands/base.py:165: RuntimeWarning: coroutine 'edit_in_external_editor' was never awaited
self.handler()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

euporie 1.3.2, OSX, export EDITOR=nvim

joouha commented 2 years ago

Hi!

I've fixed this in the dev branch here: https://github.com/joouha/euporie/commit/a740a7e6bbeeb912158d60fbc26f589cccdf8933

I'll make a new release tomorrow which includes this change

joouha commented 2 years ago

I've released v1.4.0 with the fix :+1: