joouha / euporie

Jupyter notebooks in the terminal
https://euporie.readthedocs.io
MIT License
1.54k stars 36 forks source link

Malformed config file #42

Closed ghost closed 1 year ago

ghost commented 1 year ago

The config file created by euporie lack a } at the end. Then euporie will give warnings when it starts.

joouha commented 1 year ago

I can't reproduce this. I tried deleting my configuration file, running euporie-notebook, then changing a setting. The configuration file created at is valid JSON, and no warning is shown.

Euporie doesn't create a config file unless you change a setting through the menus or the command palette. Was there a particular configuration change you made through the UI which caused this issue?

You might just need to manually fix your config file if it is broken.

ghost commented 1 year ago

You are right.

For some reason cat doesn't show the last }.

But opening the file in a text editor shows it.

It's a bug in cat???? 😲

joouha commented 1 year ago

I suspect that's because there is no new-line at the end of the config file, and your shell overwrites the last time of output in your terminal to display your prompt.

ghost commented 1 year ago

I have to report it to fish shell? To starship prompt?

I don't understand.

Is it normal that it throws out relevant information because "I have to display the prompt"?