joouha / euporie

Jupyter notebooks in the terminal
https://euporie.readthedocs.io
MIT License
1.54k stars 36 forks source link

Menu access in kitty #83

Closed raffaem closed 11 months ago

raffaem commented 1 year ago

I'm using euporie-notebook but I don't know how to access the menu bar. I thought it was ALT+F (for the file menu) but that doesn't work.

Is this documented? Because I looked in the "Keybindings" section of the docs and couldn't find it

joouha commented 1 year ago

Alt+f should open the file menu - which terminal are you using?

You can also press F10 to open the menu, or you can click on the menu with the mouse.

I seem to have missed the menu interaction shortcuts from the docs - I'll add them.

raffaem commented 1 year ago

Alt+f should open the file menu - which terminal are you using?

You can also press F10 to open the menu, or you can click on the menu with the mouse.

I seem to have missed the menu interaction shortcuts from the docs - I'll add them.

Alt+f does not work to open the menu. I'm using kitty.

F10 works and always open the file menu

raffaem commented 1 year ago

It works in Konsole, so it seems there's something wrong in my kitty

joouha commented 1 year ago

The lack of detection of the alt modifier key in kitty is because I recently switched to using kitty's keyboard protocol in kitty, but the way that kitty reports alt modifier keys is not supported by prompt_toolkit (which euporie uses for keyboard input detection).

I should be able to fix this using the progressive enhancement part of the kitty keyboard protocol.

I'm sure there's nothing wrong with your kitty.

raffaem commented 1 year ago

ok thanks

raffaem commented 11 months ago

Any news on this?

joouha commented 11 months ago

Hi - yes, this should be fixed by 3be89a4d0a5d4fca8689c73ceeed5985b64f62b4 in the dev branch

raffaem commented 11 months ago

It works wonderfully. Thanks!