Add feature merge_trees and fix some docstrings.

joowani / binarytree

Python Library for Studying Binary Trees

http://binarytree.readthedocs.io

MIT License

1.81k stars 171 forks source link

Add feature merge_trees and fix some docstrings. #25

Closed DechinPhy closed 4 years ago

DechinPhy commented 4 years ago

100% coverage tests. flake8 passed.

coveralls commented 4 years ago

Coverage remained the same at 100.0% when pulling dda34a6f6232d91e6fca9981c27e410ec7154ba2 on DechinPhy:merge_trees into 821f433ccb7b763a6d833e7c6c63ba77e7352d66 on joowani:dev.

joowani commented 4 years ago

Hi @DechinPhy,

I'm not sure if this merge function adds enough value to the library (compared to the get_parent_node function, which deals with a very common usecase when it comes to binarytrees).

joowani commented 4 years ago

Hi @DechinPhy,

Unfortunately, I don't think the merge function is a common usage when it comes to binarytree. I believe it will add more confusion to the users than usefulness so I will be closing this PR. You are always welcome to contribute (I would recommend you to create an issue to discuss the feature beforehand though). Thanks!