jopeek / fvtt-dndbeyond-character-sheet

FVTT - DNDBeyond Character Sheet for 5E
MIT License
23 stars 10 forks source link

Double 'Action' tab when Character Actions List is installed #29

Closed joevaughan closed 1 year ago

joevaughan commented 2 years ago

Foundry Version(s): v9 and v10 DnDBeyond Character Sheet Version: latest (1.9.0)

I run multiple character sheet modules (default, tidy5e, OGL, this) to give my players a choice of which they prefer so I run the Character Actions List module to give them an actions list on the default and other Character Sheets.

I know this module/sheet has an action list built in however if the Character Actions List module is installed, there is a double 'actions' tab as per the image below.

To be clear: has no functional (detrimental) effects as far asI can tell (you can click either actions tab and they work) but would be cleaner to either detect the Character Actions List module/tab and disable same or to properly integrate it as per @akrigline's request in issue #21

image

Edit: Should have said: Love the module and thanks for all your amazing work! :D

akrigline commented 2 years ago

Please note that the character actions list module is not marked ready for v10

joevaughan commented 2 years ago

Please note that the character actions list module is not marked ready for v10

I'm aware. However does seem to be functioning (for me) with no problems that I've come across yet.

brandon-hurler commented 1 year ago

I am also experiencing this same issue. Are there plans to add the additional check here or is it work that Character Actions would need to take?

jopeek commented 1 year ago

Uh I can try to figure out if it’s something I can adjust. Will try. On Jan 7, 2023 at 8:54 PM -0800, Brandon Hurler @.***>, wrote:

I am also experiencing this same issue. Are there plans to add the additional check here or is it work that Character Actions would need to take? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

brandon-hurler commented 1 year ago

Thank you for checking, I appreciate it!

jopeek commented 1 year ago

Resolved in 1.9.2