jopeek / fvtt-dndbeyond-character-sheet

FVTT - DNDBeyond Character Sheet for 5E
MIT License
23 stars 10 forks source link

Validation errors shown when closing character sheets #32

Open Leyaena opened 1 year ago

Leyaena commented 1 year ago
**Model Validation Errors**

[Actor5e.system]: Model Validation Errors
[CharacterData.spells]: Model Validation Errors
[spell1]: Model Validation Errors
[value]: must be an integer
[spell2]: Model Validation Errors
[value]: must be an integer
[spell3]: Model Validation Errors
[value]: must be an integer

Error gets shown in a toolbar popup once you close the character sheet, as well as the console. Everything else seems to be working fine, it's just a validation error showing on a big red background once you close the sheet.

Using v1.9.4

jopeek commented 1 year ago

I can't reproduce that. The [spell1..spell3] values aren't part of the sheet either. Feels like another module interfering. Can you try without any other modules or in a clean world? If you figure out which module is causing it, I can check it for compatibility issues and see if I can do something about it in my sheet.

Leyaena commented 1 year ago

I've narrowed it down with an empty world and just one character.

The issue seems to be as soon as you import a character from D&D beyond using MrPrimate's importer tool (https://github.com/mrprimate/ddb-importer), it now shows these model validation errors when interacting with your sheet.

Here's my findings:

Errors seem to pop up whenever interacting with the sheet. Changes like current HP and spell slots don't seem to persist after closing and reopening the sheet.

It's not just one imported character either, it seems to be happening for every character imported via DDB importer in our current campaign.

Hope that helps narrow things down. If you need more info, I'm happy to try and provide it.

jopeek commented 1 year ago

That helps. I do import and sync characters with that importer all the time but haven’t run into issues. Will see if I can reproduce that or not. On Jan 19, 2023 at 4:19 PM -0800, Leyaena @.***>, wrote:

I've narrowed it down with an empty world and just one character. The issue seems to be as soon as you import a character from D&D beyond using MrPrimate's importer tool (https://github.com/mrprimate/ddb-importer), it now shows these model validation errors when interacting with your sheet. Here's my findings:

• Empty character, default sheet = no problems • Empty character, dndbeyond sheet = no problems • DDB imported character, default sheet = no problems • DDB imported character, dndbeyond sheet = validation errors

Errors seem to pop up whenever interacting with the sheet. Changes like current HP and spell slots don't seem to persist after closing and reopening the sheet. It's not just one imported character either, it seems to be happening for every character imported via DDB importer in our current campaign. Hope that helps narrow things down. If you need more info, I'm happy to try and provide it. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>