jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 85 forks source link

Change settings From Player to Token #323

Open kcits opened 2 years ago

kcits commented 2 years ago

The problem I am having is if the GM controls two or more Hero Tokens and/or if a Player controls two or more tokens. It looks as though the Loot is tied to the Players not the Tokens. From my testing if there are two players that are absent from a game and the GM has to play those characters, the GM has to take control the characters, but can only take control of one at a time. The same is true if a Player has to control two tokens. Even if a Player and GM can move around and use a token, they have to take control of a Token via User Configuration to have the Token show up in the available looters.

The solution seems to change from Per Player or Player controlled Token to any Hero token if possible.

Steps to test: Add any number of Heroes greater than the number of GM + Players. Set permissions for each Hero to be Observer or greater Start game, Each Player make sure via User configuration they have one Hero selected GM place creature and kill it, make it lootable and and apply filter Only Controlled Hero Tokens will show up (if using 3 Heroes with on GM and one Player) there will always be an odd Hero Token left out.

A work around is using extra browsers and possibly having to use extra computers and make sure there is a equal player to token ratio and let the GM control any tokens from absent Players, but those player accounts have to be logged in so there is a one to one relationship with Heroes Tokens and Players.

Edit: I am Using Hero when I might want to be using Actor, and in that case maybe even Friendly Actor, but I can also see the case that a Friendly Actor is added as a NPC but is killed in battle and the players want to loot the body.

kcits commented 2 years ago

I played around with settings and see the logic that for every "friendly" token a Player account has to be associated with it. If a player is unable to attend I have to use a different browser or private tab to log in as that player. That player can then log out and the GM can take control. I also have gone through the code and see your logic and any change to just tokens and not player looks to be a big complication. This can be marked as a feature request.