search

jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 85 forks source link

Players cannot loot / trade with any of LootSheet #326

Open Aymeeeric opened 2 years ago

Aymeeeric commented 2 years ago

Describe the bug

Hi! A little (?) problem on my side. I think I have perfectly configured my loot sheets (nothing fancy here) and my players are well assigned to an actor (only one). When a player tries to interact with a loot sheet, for which he is the owner and has all the rights, it opens but he cannot do anything with it.

In console, I have systematically this stack:

image

Thank you in advance, and don't hesitate to tell me if I can bring more relevant information!

Aymeeeric commented 2 years ago

After uninstalling and reinstalling the module, resetting all its settings and checking that each player has a dedicated token: always the same thing.

When a player opens the form of a loot actor, he gets the following error in the console:

image image

It seems that "inventorySettings" has a null value: image

webmaster94 commented 2 years ago

Can confirm I am getting the same behavior. I see this was reported a month ago. I see that it hasn't been updated in two months either. I am not sure if the author is just taking a break or if they are no longer actively developing this module.

Aymeeeric commented 2 years ago

It seems that this module is no longer maintained... While waiting for an update, I switched to Monk's Enhanced Journal which does the job very well!

webmaster94 commented 2 years ago

That's what I am using now as well.

On Thu, Apr 7, 2022, 3:59 AM Aymeeeric @.***> wrote:

It seems that this module is no longer maintained... While waiting for an update, I switched to Monk's Enhanced Journal https://github.com/ironmonk88/monks-enhanced-journal which does the job very well!

— Reply to this email directly, view it on GitHub https://github.com/jopeek/fvtt-loot-sheet-npc-5e/issues/326#issuecomment-1091368363, or unsubscribe https://github.com/notifications/unsubscribe-auth/AULI4AJRNNE3UBMEYFM75GLVD2PVVANCNFSM5QRWSDPQ . You are receiving this because you commented.Message ID: @.***>

DanielBoettner commented 2 years ago

If you like, feel free to test the latest release. I started a new job and hadn't had much time the last two months.

I fixed some other issues and did not encounter this issue myself. If the error persists with the latest version I can take a look.

DanielBoettner commented 2 years ago

After reading you description again. I'm almost sure the issue will still be in the latest version. Will have to take a look at it. But this can take some time. Will have to figure out which parts are impacted.

Could you describe the "use case" in more detail?

ironocy commented 1 year ago

I'm getting a similar error when players try to buy something from the merchant sheet. It's a new problem that recently started happening. Either it doesn't let them buy anything or only buy one thing before it stops letting them buy anything. I've tried a linked and unlinked to actor merchant sheet. Happens with every merchant and PC. Merchant

IanYuy commented 1 year ago

I haven't been able to have the players loot from a loot sheet for a long while, now. Both currency and item looting just nothing when clicked. Our use case is a loot sheet actor that we use as the party inventory, where we place all gained loot and then divvy amongst ourselves.

DanielBoettner commented 1 year ago

Very sorry for the delay. Still working on converting the lootsheet to typescript for better code stability.

As I only can spare a limited time, this takes a while.

However, bugs like these should be less likely in the future. I can only ask for patience.

Terrox commented 1 year ago

I think this is how to reproduce the issue: try trading as a player with Lootsheet "loot" token.

Therefore cannot use a Lootsheet as a player controlled Henchman or Tensers Disc to hold items between scenes. (no linked sheet).