search

jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 86 forks source link

Loot Sheet not functioning for players, no ability to set permissions, visible to GM only #387

Closed grepheavy closed 1 year ago

grepheavy commented 1 year ago

Describe the bug Players are unable to access any loot sheets, double clicking the actor does nothing and doesnt load anything. In GM mode no permissions are accessible or able to be set. Can change from loot to merchant and load items but they arent even accessible to any player

To Reproduce Steps to reproduce the behavior:

  1. Create a simple loot sheet/actor
  2. load into map/scene
  3. load PC next to
  4. as PC double click on lootsheet actor
  5. no results

Expected behavior basically function as normal

Screenshots If applicable, add screenshots to help explain your problem

Desktop (please complete the following information):

lootsheeterrors

jopeek commented 1 year ago

You have to set permissions same as any other character. It’s not part of the sheet anymore. Observer let’s them open and purchase/loot. On Feb 7, 2023 at 10:26 AM -0800, grepheavy @.***>, wrote:

Describe the bug Players are unable to access any loot sheets, double clicking the actor does nothing and doesnt load anything. In GM mode no permissions are accessible or able to be set. Can change from loot to merchant and load items but they arent even accessible to any player To Reproduce Steps to reproduce the behavior:

  1. Create a simple loot sheet/actor
  2. load into map/scene
  3. load PC next to
  4. as PC double click on lootsheet actor
  5. no results

Expected behavior basically function as normal Screenshots If applicable, add screenshots to help explain your problem Desktop (please complete the following information):

• OS: windows • Browser: chrome, safari, edge

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

grepheavy commented 1 year ago

Thanks, so divided looting doesnt work?

And one has to change the loot permissions live during the game because if they do it ahead of time players can see the loot before even playing and can loot from the actors menu.

jopeek commented 1 year ago

Divided loot may work? I haven’t tested that. It’s just based on the permissions. As for having to do it live, yes. Not ideal, I know, but that’s the current state. On Feb 7, 2023 at 11:02 AM -0800, grepheavy @.***>, wrote:

Thanks, so divided looting doesnt work? And one has to change the loot permissions live during the game because if they do it ahead of time players can see the loot before even playing and can loot from the actors menu. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

arcanjl commented 1 year ago

how do we change the permissions? The only way I know how is the in the actor's section, and that is by changing the prototype, which I don't want to do. Is there a way to change the token by itself?

jopeek commented 1 year ago

I don’t think so, no. On Feb 24, 2023 at 9:20 AM -0800, arcanjl @.***>, wrote:

how do we change the permissions? The only way I know how is the in the actor's section, and that is by changing the prototype, which I don't want to do. Is there a way to change the token by itself? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Sgiath commented 1 year ago

With this change, this module is pretty much useless - either players cannot open the loot sheet or they can see whole stats for the creature in the Actors tab 🤷🏻

jopeek commented 1 year ago

What actors tab? There’s no actors tab on the lootsheet. On Mar 6, 2023 at 5:47 AM -0800, Filip Vavera @.***>, wrote:

With this change, this module is pretty much useless - either players cannot open the loot sheet or they can see whole stats for the creature in the Actors tab 🤷🏻 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Ferliczkoni commented 1 year ago

@jopeek I have given my players the observer rights, and they now can open the chest but the loot button is not working.

jopeek commented 1 year ago

Can they see it and click it but nothing happens? If so, I will have to review the loot button code. I haven’t checked it in a while. On Mar 6, 2023 at 7:32 AM -0800, Ferliczkoni @.***>, wrote:

@jopeek I have given my players the observer rights, and they now can open the chest but the loot button is not working. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Ferliczkoni commented 1 year ago

Yes, that's the case. They can see it but pressing the loot button does nothing at all.

jopeek commented 1 year ago

Ok I’ll try to fix that this week sometime. On Mar 6, 2023 at 7:35 AM -0800, Ferliczkoni @.***>, wrote:

Yes, that's the case. They can see it but pressing the loot button does nothing at all. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Sgiath commented 1 year ago

@jopeek I used it as follows:

  1. have a creature template in Actors (with items and money attached), create a bunch of unlinked tokens on the map, and run combat with them
  2. once the creature is defeated, change the sheet to Loot sheet and give users permission to loot it

Now I have to give them permission to access the actor template so they can loot tokens on the map, but if they go to the "Actors" tab on the right they can see creatures' whole stats.

jopeek commented 1 year ago

I see what you’re saying. That was always a problem, wasn’t it? The on-sheet permission controls did the exact same thing. I don’t think it’s possible to give permissions only to a specific token and not the actor… On Mar 7, 2023 at 1:19 AM -0800, Filip Vavera @.***>, wrote:

@jopeek I used it as follows:

  1. have a creature template in Actors (with items and money attached), create a bunch of unlinked tokens on the map, and run combat with them
  2. once the creature is defeated, change the sheet to Loot sheet and give users permission to loot it

Now I have to give them permission to access the actor template so they can loot tokens on the map, but if they go to the "Actors" tab on the right they can see creatures' whole stats. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

Sgiath commented 1 year ago

I would swear it was working before but my memory is not perfect :)

grepheavy commented 1 year ago

What actors tab? There’s no actors tab on the lootsheet. … On Mar 6, 2023 at 5:47 AM -0800, Filip Vavera @.>, wrote: With this change, this module is pretty much useless - either players cannot open the loot sheet or they can see whole stats for the creature in the Actors tab 🤷🏻 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.>

if i give them permission to see the actor for the loot, then they can easily see that actor in their "actors" panel, its not hidden in any way.

tingle-berry commented 1 year ago

Still getting this issue, has there been a fix yet?

vtt version: 10.291 loot sheet version: 5.06

image

jopeek commented 1 year ago

No. I don’t consider this a bug but a missing feature which I have no time to add. On May 31, 2023 at 4:50 PM -0700, tingle-berry @.***>, wrote:

Still getting this issue, has there been a fix yet? vtt version: 10.291 loot sheet version: 5.06 — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

jopeek commented 1 year ago

Permissions are back