jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 86 forks source link

GM Permissions and GM Coin Distribution Sections of Loot Sheet Not Shown #390

Closed Drakynn closed 1 year ago

Drakynn commented 1 year ago

Describe the bug When creating a "loot" npc, the normal GM sections where you can assign permissions and split the coin among players do not appear. GM is not able to determine who gets loot share or control access to loot sheet.

Players are able to click the diamond and loot all of the coin or take individual items from a loot sheet.

Players are able to purchase items from a merchant sheet.

To Reproduce Steps to reproduce the behavior:

  1. Create an NPC character.
  2. Set the sheet to dnd5e.LootSheet5eNPC
  3. In GM Settings, type of sheet is set to "Loot" by default.

Expected behavior Expect to see interface as documented in multiple screenshots in README.md

Screenshots Expected view

lootsheetA

Actual view - no permissions, no coin distribution

lootsheetB

Desktop (please complete the following information):

Notes Duplicate of part of what was reported in Issue #387 , however I'm not having any problems from player perspective.

Many console deprecation warnings, but no errors reported.

jopeek commented 1 year ago

That function is not available anymore. You can use the regular permissions screen to grant access. I need to update the readme to remove those references. On Feb 11, 2023 at 8:26 PM -0800, Drakynn @.***>, wrote:

Describe the bug When creating a "loot" npc, the normal GM sections where you can assign permissions and split the coin among players do not appear. GM is not able to determine who gets loot share or control access to loot sheet. Players are able to click the diamond and loot all of the coin or take individual items from a loot sheet. Players are able to purchase items from a merchant sheet. To Reproduce Steps to reproduce the behavior:

  1. Create an NPC character.
  2. Set the sheet to dnd5e.LootSheet5eNPC
  3. In GM Settings, type of sheet is set to "Loot" by default.

Expected behavior Expect to see interface as documented in multiple screenshots in README.md Screenshots Expected view Actual view - no permissions, no coin distribution Desktop (please complete the following information):

• OS: Win 11 and MacOS 13.1 • Browser: Latest Chrome and Firefox

Notes Duplicate of part of what was reported in Issue #387 , however I'm not having any problems from player perspective. Many console deprecation warnings, but no errors reported. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Drakynn commented 1 year ago

What about the coin share option?

jopeek commented 1 year ago

Also not available. I may bring that back but not sure yet. Was a giant pain to make purchases and transactions work in the first place. Unfortunately, the dnd5e system changes its internal workings so frequently, it’s been hard to keep up with, so I’ve had to focus on the bare basics. On Feb 11, 2023 at 9:17 PM -0800, Drakynn @.***>, wrote:

What about the coin share option? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Drakynn commented 1 year ago

Permissions is an easy adjustment to make, but the coin split is a popular feature and reason many people use(d) this module.

I was able to find a coin split macro and update it to the current 5e schema where it's using actor.system.currency.pp. It's not as elegant as your solution but it works.