jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 86 forks source link

Errors when changing to Loot Sheet Simple #394

Closed HippyCraig closed 1 year ago

HippyCraig commented 1 year ago

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior: Create a new NPC no custimizations, no token assigned other than the default mystry man Change sheet to loot Cant open character sheet any more

Expected behavior Sheet to appear looking like the loot sheet

Screenshots First Insatlling the module from the main window doesnt change to gray after installation I assume thats becuase the name doesnt match the listing. New name shows Loot Sheet NPC 5e (Simple Version) as you can see the install in the Install Module is not grayed out even though its installed, other than the display name diff. image

When added to a sheet I get the following error in the console, not sure if this is related to the mystry man icon as there seems to be a ref to Default_Token Not set image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

jopeek commented 1 year ago

What foundry version and what version of dnd5e? On Mar 18, 2023 at 8:14 AM -0700, HippyCraig @.***>, wrote:

Describe the bug A clear and concise description of what the bug is. To Reproduce Steps to reproduce the behavior: Create a new NPC no custimizations, no token assigned other than the default mystry man Change sheet to loot Cant open character sheet any more Expected behavior Sheet to appear looking like the loot sheet Screenshots First Insatlling the module from the main window doesnt change to gray after installation I assume thats becuase the name doesnt match the listing. New name shows Loot Sheet NPC 5e (Simple Version) as you can see the install in the Install Module is not grayed out even though its installed, other than the display name diff. When added to a sheet I get the following error in the console, not sure if this is related to the mystry man icon as there seems to be a ref to Default_Token Not set Desktop (please complete the following information):

• OS: Win10 • Browser Chrome • Version 111.0.5563.65 (Official Build) (64-bit)

Additional context Add any other context about the problem here. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

HippyCraig commented 1 year ago

Sorry forgot to add that 5e - 2.1.5 Foundry v10.291

I also noticed now when I go back in for some reason all the NPC are stuck with the loot sheet and I cant open them anymore, its just a test game so its not impacting me, but thought it was worth mentioning. Even the ones with Proper tokens images wont open here are the errors Im seeing now:

This is from opening an NPC on the canvas nothing open but this is in hte console image and sometimes this image

jopeek commented 1 year ago

Very odd. I tested this in a clean game and didn’t have any of those issues. I’m running my weekly game today so I’ll have a look. If I can reproduce it, I can fix it. On Mar 18, 2023 at 8:23 AM -0700, HippyCraig @.***>, wrote:

Sorry forgot to add that 5e - 2.1.5 Foundry v10.291 I also noticed now when I go back in for some reason all the NPC are stuck with the loot sheet and I cant open them anymore, its just a test game so its not impacting me, but thought it was worth mentioning. Even the ones with Proper tokens images wont open here are the errors Im seeing now: This is from opening an NPC on the canvas nothing open but this is in hte console

and sometimes this — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

jopeek commented 1 year ago

The first part, about the module not appearing in grey in the installer is not something I'm going to try to fix. I'm not sure how Foundry determines that and anything I try to do will likely just cause problems for people using the older version. It's likely related to the fact that I used the same package for this new version but I didn't feel like going through submitting a new package entirely to foundry...

jopeek commented 1 year ago

Tracked down the bug you experienced and fixed it in 5.0.5. Was related to it attempting to display spells after changing an NPC to the loot sheet type. I've ensured that spells don't appear anymore. Should help. Open a new ticket if you get any further errors. The screenshots and line numbers in particular helped me track this down. Thanks!

HippyCraig commented 1 year ago

Thanks everything is working again!!!