jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 86 forks source link

Problems with some thumbnail images on items #397

Open Fridan99 opened 1 year ago

Fridan99 commented 1 year ago

Describe the bug Some item's thumbnails images doen'st appear in the loot sheet, I suspect that image routes/path that include a % are not detected by the loot sheet.

To Reproduce Steps to reproduce the behavior:

  1. Create an item with a thumbnail image path that includes a % simbol
  2. Open the loot sheet from an npc

Foundry version and System Foundry v10.291 System dnd5e 2.2.1 Loot Sheet 5e 5.0.6 (latest version)

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

The thumbnail image of the item appears as normal (Tidy5e sheet) 1 1

The thumnail image of the item is missing (lootsheet 5e sheet) 1 11

Desktop (please complete the following information):

Additional context

There seems to be a problem with the item's thumbnails images on the loot sheet.

I've only had this happen with items from the wanderer's guide to merchants & magic module. I noticed that all the paths of that module for the image have the % character, maybe that's it... with the rest of the sheets (default, tidy5e...) the thumbnail of the item appears correctly.

example of data path: modules/wanderers-guide-2-merchants-n-magic/Magic%20Items%20(Art)/Arctic%20Ring.webp

jopeek commented 1 year ago

I’ll see if I can replicate this with an image with the % character in it. On Jun 25, 2023 at 2:18 PM -0700, Fridan99 @.***>, wrote:

Describe the bug Some item's thumbnails images doen'st appear in the loot sheet, I suspect that image routes/path that include a % are not detected by the loot sheet. To Reproduce Steps to reproduce the behavior:

  1. Create an item with a thumbnail image path that includes a % simbol
  2. Open the loot sheet from an npc

Foundry version and System Foundry v10.291 System dnd5e 2.2.1 Expected behavior A clear and concise description of what you expected to happen. Screenshots If applicable, add screenshots to help explain your problem. The thumbnail image of the item appears as normal (Tidy5e sheet) The thumnail image of the item is missing (lootsheet 5e sheet) Desktop (please complete the following information):

• OS: [e.g. Windows 10] • Browser [chrome] and Foundry app itself • Version [114.0.5735.134 (Build oficial) (64 bits)]

Additional context There seems to be a problem with the item's thumbnails images on the loot sheet. I've only had this happen with items from the wanderer's guide to merchants & magic module. I noticed that all the paths of that module for the image have the % character, maybe that's it... with the rest of the sheets (default, tidy5e...) the thumbnail of the item appears correctly. example of data path: modules/wanderers-guide-2-merchants-n-magic/Magic%20Items%20(Art)/Arctic%20Ring.webp — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Fridan99 commented 1 year ago

ok, let me know if you need anything

jopeek commented 1 year ago

Does the image show up fine in the default sheet? Lootsheet isn’t doing anything special with the items and their images. On Jun 25, 2023 at 2:36 PM -0700, Fridan99 @.***>, wrote:

ok, let me know if you need anything — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Fridan99 commented 12 months ago

Yes, it works in the default sheet. I am observing that these are HTML type images.

Default sheet 1 1

Loot sheet 1 12

jopeek commented 12 months ago

How would I get those items? They’re not in the SRD compendium. On Jul 10, 2023 at 7:24 AM -0700, Fridan99 @.***>, wrote:

Yes, it works in the default sheet. I am observing that these are HTML type images. Default sheet Loot sheet — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Fridan99 commented 12 months ago

i sent you to your gmail some items that reflect the problem.

jopeek commented 12 months ago

Thanks, I’ll take a look later this week. On Jul 11, 2023 at 2:28 PM -0700, Fridan99 @.***>, wrote:

i sent you to your gmail some items that reflect the problem. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>