jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 86 forks source link

Installing from Manifest URL always installs latest version #403

Open kaelad02 opened 12 months ago

kaelad02 commented 12 months ago

I wanted to install version 5.0.6 on my Foundry v10 install but couldn't. When I installed the normal way through Foundry's Install Module interface, it installed the latest (version 11.222.1). I uninstalled it and then went to the Foundry listing for the module, https://foundryvtt.com/packages/lootsheetnpc5e, and copied the Manifest URL for version 5.0.6 and installed with that but it still installed the latest version.

Looking in the module.json file, the download url is https://github.com/jopeek/fvtt-loot-sheet-npc-5e/archive/lootsheet-simple.zip which just links to the latest version of the source code. That explains why I got version 11.222.1. If you're not going to attach assets to the releases but just rely on GitHub's ability to just grab a zip of the repo, can you change the URLs to be versioned?

For example, the 5.0.6 version could be registered with Foundry's listing to have a Manifest URL of https://raw.githubusercontent.com/jopeek/fvtt-loot-sheet-npc-5e/5.0.6/module.json. Then inside that module.json file, you could point the download property to https://github.com/jopeek/fvtt-loot-sheet-npc-5e/archive/refs/tags/5.0.6.zip