search

jopeek / fvtt-loot-sheet-npc-5e

FVTT - Loot Sheet NPC 5E
MIT License
44 stars 86 forks source link

Changing permissions resets the sheet #404

Open Seledrex opened 11 months ago

Seledrex commented 11 months ago

Describe the bug When changing the permissions of the sheet, the sheet resets to its default state. All items added to the sheet are removed, and the type is set back to Loot. Additionally, none of the players are shown in the Permissions anymore until the sheet is closed and reopened.

To Reproduce Steps to reproduce the behavior:

  1. Create a NPC token
  2. Open the sheet and set the sheet configuration to loot sheet NPC
  3. Change type to Merchant
  4. Add items to sheet
  5. Change permissions
  6. Sheet gets reset

Expected behavior Changing permissions does not reset the sheet.

Screenshots

Animation

Desktop (please complete the following information):

jopeek commented 11 months ago

Strange. I haven’t noticed that myself but I will test that out this weekend. On Jul 26, 2023 at 11:58 PM -0700, Eric Auster @.***>, wrote:

Describe the bug When changing the permissions of the sheet, the sheet resets to its default state. All items added to the sheet are removed, and the type is set back to Loot. Additionally, none of the players are shown in the Permissions anymore until the sheet is closed and reopened. To Reproduce Steps to reproduce the behavior:

  1. Create a NPC token
  2. Open the sheet and set the sheet configuration to loot sheet NPC
  3. Change type to Merchant
  4. Add items to sheet
  5. Change permissions
  6. Sheet gets reset

Expected behavior Changing permissions does not reset the sheet. Screenshots Desktop (please complete the following information):

• OS: Windows 10 • Foundry VTT 11.306 • FVTT Loot Sheet NPC 11.222.1

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

Seledrex commented 11 months ago

Thanks that would be great!

jopeek commented 11 months ago

Yeah confirmed. Very strange. Not quite sure if a fix yet but I’ll spend some time. Worksround is to set up the sheet with all the items first, then do the permissions. On Jul 27, 2023 at 8:52 AM -0700, Eric Auster @.***>, wrote:

Thanks that would be great! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>

Seledrex commented 11 months ago

Yeah confirmed. Very strange. Not quite sure if a fix yet but I’ll spend some time. Worksround is to set up the sheet with all the items first, then do the permissions.

Thanks for having a look, and thanks for the workaround. Looking forward to a fix if possible!

jopeek commented 11 months ago

Simply refreshing the browser also seems to fix it. On Jul 28, 2023 at 11:32 AM -0700, Eric Auster @.***>, wrote:

Yeah confirmed. Very strange. Not quite sure if a fix yet but I’ll spend some time. Worksround is to set up the sheet with all the items first, then do the permissions. Thanks for having a look, and thanks for the workaround. Looking forward to a fix if possible! — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you commented.Message ID: @.***>