search

jopemachine / alfred-chrome-workflow

Chromium based browser workflow for Alfred 4
https://www.npmjs.com/package/alfred-chrome-workflow
MIT License
39 stars 3 forks source link

Support for other browsers #12

Closed hawkeng closed 2 years ago

hawkeng commented 2 years ago

First of all, thanks for creating this workflow, it has been really helpful!

I wanted to know what are your thoughts on extending the config file to support more Chromium-based browsers?

I use Brave Browser, so I had to fork this repo and tweak the code a bit to make it work with Brave. Instead of just adding a new URL to getDBFilePath I figured I could make it even more flexible if I just included a config property that allowed me to specify the browser support directory.

You can check my commit here.

If you agree and are okay with the changes, I can create a PR, otherwise thanks for your time.

jopemachine commented 2 years ago

Sure, I'm glad to hear that this workflow is useful to you.

I think it makes sense to create browser_dir option to support more other chromium-based browsers.

Please feel free to make a PR about this.

I appreciate your contribution.

jun6lee commented 2 years ago

I haven't been as elegant as @hawkeng, but have nonetheless added Brave support as a pull request.