search

jopenlibs / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://jopenlibs.github.io/vault-java-driver
26 stars 18 forks source link

Add custom Vault Authentication Path when using k8s login method #27

Closed dttung2905 closed 1 year ago

dttung2905 commented 1 year ago

Hi @jopenlibs,

Thanks for maintaining this fork so actively. You are doing a great work for the community :pray:

This PR aims to solve the hardcoding authentication path for Vault. This is extracted from the official doc

The default endpoint is auth/kubernetes/login. If this auth method was enabled at a different path, use that value instead of kubernetes

This is related to another issue https://github.com/lensesio/secret-provider/issues/46 that I'm trying to fix ( and hopefully pin the vaul-java-driver dependencies to your fork :crossed_fingers: )

Do let me know if you have any comments/ feedback on this.

dttung2905 commented 1 year ago

Hi @henryx, Could you help to take a look at this PR if you have time please :pray: ?

henryx commented 1 year ago

Hi @dttung2905, thank you for you PR, I've viewed it and for me is good. After the merge, I release ASAP the new version, to accomplish your work. In future, feel free to write tests for this part (sadly, I have no idea how to mock them)

dttung2905 commented 1 year ago

Hi @henryx, Thanks for the quick reply and the approval. May I know the latest new version would be 5.3.0 according to this page right?

henryx commented 1 year ago

@dttung2905 yes I've released the latest version. Sadly, for now, I cannot uploaded to Maven Central, so you need to build it manually

dttung2905 commented 1 year ago

@henryx thanks for the help to release. Is there any timeline that we can solve the maven central problem?