search

jopenlibs / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://jopenlibs.github.io/vault-java-driver
26 stars 18 forks source link

Add overloading method loginByKubernetes() with custom authPath #29

Closed dttung2905 closed 1 year ago

dttung2905 commented 1 year ago

Hi @henryx,

This PR adds an overloading method for loginByKubernetes() as this new method accepts a new arg authPath. I should have included this in the previous PR #27 , so sorry about that. :disappointed:

In my downstream code, I could use the new method loginByJwt() directly but I just want to make the vault-java-driver code base consistent, to avoid confusion for other users :pray:

henryx commented 1 year ago

Hi @dttung2905 ,

Don't worry and thank you. Sadly, this part lacks of tests, so is more simple to break something. I merge it, so that it will be present in future releases