search

jopenlibs / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://jopenlibs.github.io/vault-java-driver
26 stars 18 forks source link

httpURLConnection.getErrorStream() can return null so handle it. #31

Closed brycechesternewman closed 1 year ago

brycechesternewman commented 1 year ago

Fixes https://github.com/jopenlibs/vault-java-driver/issues/30

brycechesternewman commented 1 year ago

Hi @henryx or @tledkov. Can I please get some eyes on this PR?

henryx commented 1 year ago

Hi @brycechesternewman, thank you for your PR. For me it's ok, but before merge it, can you write a test to verify the problem? I'm not sure if is possible, but if you can, it would be very appreciated

brycechesternewman commented 1 year ago

@henryx howdy. Can you have another look please?

brycechesternewman commented 1 year ago

@henryx Thank you for merging. What is your typical release schedule? I want to make use of this asap. Thanks again.

henryx commented 1 year ago

I've released new version with this patch. For some reasons, publishing to Maven Central is a bit slow. If you need asap this release, you can use jitpack.io as as alternate package repository

brycechesternewman commented 1 year ago

I am not yet seeing 4.5.0 published to maven central https://repo1.maven.org/maven2/io/github/jopenlibs/vault-java-driver/. Perhaps it is not replicated yet?