search

jopenlibs / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://jopenlibs.github.io/vault-java-driver
26 stars 18 forks source link

[IMPROVEMENT] Upgrade gradle's required version #32

Closed henryx closed 1 year ago

henryx commented 1 year ago

At the moment, the project is built using Gradle 5.6.4. According to this issue, this version cannot be used with Java greather than 11. This is a problem because it doesn't allow updating the Java version used for project development. therefore it is necessary to carry out the activities necessary to allow Gradle to be updated, in particular by rewriting the deprecated parts in the new versions. An alternative is change the build system (with Maven or other), but it is preferrable to adopt this way as extrema ration

kLeZ commented 1 year ago

Trying to help on this. Just forked.

HomeOfTheWizard commented 1 year ago

Hi @henryx ,

I have created the following PR https://github.com/jopenlibs/vault-java-driver/pull/39, a minimum work just to unblock https://github.com/jopenlibs/vault-java-driver/issues/22.

Tested the unitTest all is working, however I realized that 3 integrationTests don't pass with the latest version of the Vault image because the API returns 204 instead of 200. I did not change the tests in case you use a specific version of the image in your CI environment.

io.github.jopenlibs.vault.api.AuthBackendPkiTests > testRevocation FAILED
    junit.framework.AssertionFailedError at AuthBackendPkiTests.java:168
io.github.jopenlibs.vault.api.AuthBackendPkiTests > testIssueCredential FAILED
    junit.framework.AssertionFailedError at AuthBackendPkiTests.java:100
io.github.jopenlibs.vault.api.AuthBackendPkiTests > testIssueCredentialWithCsr FAILED
    junit.framework.AssertionFailedError at AuthBackendPkiTests.java:141

But I think we must fix them and alway run the tests with the latest image of Vault.

@kLeZ please continue feel free to continue your work in case you see other improvements or changes related to the new APIs of gradle. I am new to gradle so I may have missed some things.

henryx commented 1 year ago

@HomeOfTheWizard Thank you so much for you PR, I've merged it in mainline before check the CI result