search

jopenlibs / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://jopenlibs.github.io/vault-java-driver
29 stars 18 forks source link

add possibility to pass preconfigured http client to reuse http/tls resources for consequent requests #44

Closed samfrown closed 1 year ago

samfrown commented 1 year ago

Hi.

This address the known issue from the base repo: https://github.com/BetterCloud/vault-java-driver/issues/239.

The idea is to pass a preconfigured HttpClient to VaultConfig and then reuse it by consequent requests done by the same Vault instance. This improves performance and takes full advantages of HTTP/2 protocol by sharing http connections. The changes cover only user API so far.

henryx commented 1 year ago

Hi @samfrown, thank you for the PR. For me is a good idea, so I've reviewed the PR and for me is able to be merged

samfrown commented 1 year ago

Thanks @henryx! When this can be released?