jopenlibs / vault-java-driver

Zero-dependency Java client for HashiCorp's Vault
https://jopenlibs.github.io/vault-java-driver
26 stars 18 forks source link

[IMPROVEMENT] Add PKCS8 Private Key Support on PKI Issue. #61

Closed grrolland closed 1 month ago

grrolland commented 1 month ago

Is your feature request related to a problem? Please describe. When issuing private key from PKI, the format of the private key is, by default PKCS1. PKCS1 is badly supported by java. It would be nice to support the PKCS8 format since vault support it.

Describe the solution you'd like When calling pki.issue, add parameter to specify private key format

Additional context Vault PKI support this since 0.9.0 : https://github.com/hashicorp/vault/pull/3518

henryx commented 1 month ago

Thank you for the PR, I'll viewed it and I appreciate your work. ASAP I'll release new version with this PR

grrolland commented 1 month ago

Many thanks !