search

jopetty / Huruf

A simple chrome extension to make reading Arabic easier
25 stars 5 forks source link

partially rendered text in YouTube (Resolved) #8

Closed AmenJlili closed 5 years ago

AmenJlili commented 5 years ago

It seems that there is a problem with the regex expression that evaluates if the text is Arabic or not on YouTube.

image

basshelal commented 5 years ago

@jliliamen Hi there! I believe this may be a problem unique to YouTube, refreshing the page should probably work.

YouTube recently changed the way they implement a visit to a new page on the same tab. Instead of opening a whole new page and session, it just changes the content on the current page, like many web apps do. This is problematic for this extension.

My fork fixes this specific issue because it solves the issue of not updating dynamically loaded content, but it introduces a new bug where if you visit a different YouTube page after being on one with Arabic script, the old script will remain, making the new English text either not appear or have Arabic next to it as well. I explain this a bit more on the pull request

This extension has quite a few issues and unfortunately the original author hasn't responded to anything, so I'm thinking of taking it for myself, it's too useful and valuable to be left aside like this. If you have any features in mind, let me know, I plan on improving this when I have time. I have already planned 3 new features, an on off button that I just made working on my fork, more fonts like Nastaliq for Urdu users, and a whitelist feature for websites that don't work well with it like quran.com. Hopefully I'll have the time and patience to implement these.

Peace to you :)

AmenJlili commented 5 years ago

Good job man! Can you upload your fork to the chrome web store?

basshelal commented 5 years ago

@jliliamen Thanks :) If the original author doesn't respond to my pull request soon I'll probably do something like that with the extra features sometime. I'll let you know when I do that though, thanks :) In the meantime if you must have the newest features you can install the extension unpacked from my fork

AmenJlili commented 5 years ago

Very appreciated. Thanks brother!

basshelal commented 5 years ago

@jliliamen Hi brother :) I've uploaded my version on the Chrome Web Store. Here's the store page Here's the GitHub repo Hope this helps you in some way, peace to you :)

AmenJlili commented 5 years ago

@basshelal This is amazing. Your work is perfect! I like how the page updates when you change the font. Thank you very much, brother! Can I buy you a cup of coffee (I will PayPal you)? Peace be with you!

basshelal commented 5 years ago

@jliliamen Thank you for your very kind words my friend, I really do hope it helps you. I'm always up for feedback so if there's any issues feel free to tell me. That's fine man I already drink too much coffee anyway lol, Eid Mubarak brother :)

AmenJlili commented 5 years ago

I would like to offer you something for your hard work but no pressure brother. Eid Mubarak to you too and thank you for your hard work!

orehmane commented 5 years ago

@basshelal Would it be possible to get your fork on Firefox as well? It is very valuable, thank you for your work!

orehmane commented 5 years ago

@basshelal Never mind, I found that you already did it. May Allah reward you.

AmenJlili commented 5 years ago

Excellent fork at this link with a lot more features: https://github.com/basshelal/Wudooh