search

joplin / plugin-abc-sheet-music

ABC Sheet Music Plugin for Joplin
GNU General Public License v3.0
40 stars 4 forks source link

Is it possible to add numbered musical notation? #12

Open sysescool opened 5 months ago

sysescool commented 5 months ago

I notice plugin-abc-sheet-music is about abcjs.

I search that: Is it possible to add numbered musical notation?

I notice in this repo the code: https://github.com/joplin/plugin-abc-sheet-music/blob/2b128c7a21f010e9937a112e0cf1fb5c03f9ca75/src/markdownItPlugin.ts#L56

But I don't know how to make it.

Is it possible to add numbered musical notation in joplin?

laurent22 commented 5 months ago

If it's not directly supported by abcjs, it's likely out of scope for this particular plugin. I wouldn't be opposed to a pull request that would add this though.

sysescool commented 3 months ago

@laurent22 Suppose, I mean, if I were to write this function, based on your understanding of abcjs and Joplin, do you think it would be better to contribute it to the original abcjs repository, or to implement this function through a Joplin plug-in?

laurent22 commented 3 months ago

@laurent22 Suppose, I mean, if I were to write this function, based on your understanding of abcjs and Joplin, do you think it would be better to contribute it to the original abcjs repository, or to implement this function through a Joplin plug-in?

It would be much better on the abcjs website since everybody would benefit from it, and integration would also be better. The repo still seems to be active so it's worth a try, although maybe ask them anyway to be sure.