joplin / plugin-bibtex

Use locally stored BibTeX files to integrate citation into Joplin
30 stars 7 forks source link

Customize search #18

Closed xUser5000 closed 3 years ago

xUser5000 commented 3 years ago

What has been done

Screenshots

1 2 3 4

xUser5000 commented 3 years ago

Does it also work with a query like "erdos 1970" (author/year)?

Unfortunately, no

laurent22 commented 3 years ago

Unfortunately, no

Would such a search type be difficult to implement? i.e. the query "erdos 1970" is split into "erdos" and "1970", then your search routine returns all the results that contain any of these words in any of the fields.

xUser5000 commented 3 years ago

Would such a search type be difficult to implement? i.e. the query "Erdos 1970" is split into "erdos" and "1970", then your search routine returns all the results that contain any of these words in any of the fields.

Actually, this is a good idea, but it is gonna be tricky to implement. I will have to intercept the search query, split it up into multiple tokens, get the results of searching with every token, and then group all the results without duplication.

xUser5000 commented 3 years ago

Done

laurent22 commented 3 years ago

All good now 👍

laurent22 commented 3 years ago

By the way, when merging, do you prefer "Squash and merge" or just a regular merge?

xUser5000 commented 3 years ago

By the way, when merging, do you prefer "Squash and merge" or just a regular merge?

For keeping a clean history, I prefer "Squash and merge"