joplin / plugin-email

This plugin adds the ability to fetch email messages and converts them to Joplin notes in various formats, either by monitoring any new or unread messages from a specific email address or a specific mailbox, or by uploading downloaded email messages to the plugin without having to be logged in.

29 stars 4 forks source link

week 4 & 5 #4

Closed bishoy-magdy closed 2 years ago

bishoy-magdy commented 2 years ago

What has been done

Rename emailParser file to emailConfigure.
Installed IMAP and its requirements and made the first IMAP connection in the plugin (SSL/TLS).
Added the manual connection screen.
Created the Main Screen.
Open/Close Monitoring based on 'from'.
Logout button
Created an error alarm, a warning alarm when an error is caused while logging monitoring (using alert)

Make sure when logging in to Gmail using the app password and turning on imap, but other email providers, just create the app password.

To turn on imap

1. On your computer, open Gmail. 2. In the top right, click Settings Settings and then See all settings. 3. Click the Forwarding and POP/IMAP tab. 4. In the "IMAP access" section, select Enable IMAP. 5. Click Save Changes.

To create an app password link

laurent22 commented 2 years ago

@bishoy-magdy, could you setup some linter on your repo as indentation is inconsistent? At a minimum it should use tabs and I feel things like strict equality should be required. See if you can use the eslintc file from the main repo: https://github.com/laurent22/joplin/blob/dev/.eslintrc.js If it's too complicated to get it working you can disable some of the rules.

bishoy-magdy commented 2 years ago

@bishoy-magdy, could you setup some linter on your repo as indentation is inconsistent? At a minimum it should use tabs and I feel things like strict equality should be required. See if you can use the eslintc file from the main repo: https://github.com/laurent22/joplin/blob/dev/.eslintrc.js If it's too complicated to get it working you can disable some of the rules.

Yes, sure. I added eslint with Google extend and added some rules from the Joplin repo.

If there is something else, please tell me. Thanks.

roman-r-m commented 2 years ago

One thing I've noticed when trying the plugin is that the panel opens on every start even if I closed it before. Ideally I think the plugin should remember this and not reopen the panel

bishoy-magdy commented 2 years ago

One thing I've noticed when trying the plugin is that the panel opens on every start even if I closed it before. Ideally I think the plugin should remember this and not reopen the panel

Yes, also this problem occurs when the main screen starts and enters the email and closes the panel, which when opened again will open the main screen without saving the email.

I mentioned this problem in the weekly report and I will solve this problem this week.

bishoy-magdy commented 2 years ago

One thing I've noticed when trying the plugin is that the panel opens on every start even if I closed it before. Ideally I think the plugin should remember this and not reopen the panel

I am trying to produce this issue on Linux and Windows, but the plugin remembers its last state and work fine, so is there a way to produce this issue?

https://user-images.githubusercontent.com/58605547/182437506-0db6b3d2-3cbe-4990-80d4-6396a032d90d.mp4

roman-r-m commented 2 years ago

Yes, you're right. Not sure what I did back then but now it seems to be working correctly.

I also see this hasn't been merged - will do now.