Add "Close" button to close kanban and disable auto closing

[benlau]

Implements #21

• Added a "close" button at the left of the kanban title to close kanban
• Disabled auto closing if user open a note which is not in the current kanban (as user could close the kanban by using the close button)

[mhelleboid]

This works as described.

The board lifecycle seems to have change a bit, but it seems ok.

Not sure that the initial feature request suggested to also disable the "auto closing". In this case this could be an option. Anyway, this can be done in an additional commit/branch.

[benlau]

@mhelleboid Thanks for reviewing!

yes, the auto closing is not described in the feature requirement.

However, as we now have a close button and therefore I think auto closing is not needed anymore as user could choose when should it be closed. It is more flexible.

Example:

1. Edit a kanban board
2. User find that a note should be added to the kanban
3. Open the note and change folder/tag to add to kanban
4. The board closed and user need to open the kanban again to resume the works but it may need to wait for a few seconds for reloading

Disable the auto closing feature could save the time for reloading in step 4

@PackElend , what do you think?

[mhelleboid]

Ok the scenario makes sense, and I agree that this is a good thing

[PackElend]

Sounds good but let me check the history why auto close exsist

[benlau]

@PackElend thx. If it is approved, I may try to work on a feature to drag a note from note list to a Kanban column directly.

[PackElend]

could find anything and still don't see a reason to keep auto close but others may think differently. I started a "survey", see https://discourse.joplinapp.org/t/shall-we-replace-auto-close-by-close-button/31440

[PackElend]

let's wait for a week, if it is not significant response I'll merge it

[PackElend]

I may try to work on a feature to drag a note from note list to a Kanban column directly.

@benlau please go ahead but open a topic in the forum as well, to allow the community to join the development :)

[mhelleboid]

The code and the PR is ok for me, from a technical and functional (auto close) point of view

[PackElend]

@benlau do you want to add some comments / do changes due to the latest review, if necessary?

So that I can merge it.

[benlau]

@PackElend I think it should be ready to merge. thx

[AndiLeni]

@benlau Sorry to comment on this old pr, but how do I activate this feature? The button is missing on my end.

[benlau]

@AndiLeni I think the change is not published yet.

@PackElend Do you have the permission to release a new version?

[PackElend]

Do you have the permission to release a new version?

will check

[PackElend]

@mhelleboid @benlau

Eventually GSoC is rolling smoothly and we are looking into other things. We get errors when we build it:

> joplin-plugin-kanban@1.0.7 prepare
> npm run dist

> joplin-plugin-kanban@1.0.7 dist
> webpack --joplin-plugin-config buildMain && webpack --joplin-plugin-config buildExtraScripts && webpack --joplin-plugin-config createArchive

do you get the same when you do that?

it is discussed in https://discord.com/channels/610762468960239627/919979500765335613/1240377195730440274

[PackElend]

https://github.com/joplin/plugin-kanban/pull/50 could fix it, let's see.